- Queued RPC calls would cause crashes due to invalid pointers to request/response and/or controller; this has been fixed
- PbRpcController now takes ownership of request and response messages and
will delete them when it itself is being deleted
- This design mandates that request and response messages for each RPC call
have to be allocated on the heap.
- The convention for the Closure 'done' call now is to allocate and pass a
pointer to the controller object to it which will delete it after use;
this requires that controller itself be also allocated on the heap
(NOTE: this is just a convention - not mandatory)
- All existing RPC calls (in portgroup.cpp) have been changed to follow the
above convention
- Reordering of queued RPC calls has been fixed
- PortManager is now destroyed at exit; because of this fix the per port temporary capture files are auto-removed at exit
- WinPcapPort destructor no longer deletes the monitor threads because the parent class PcapPort already does it
- Capture does not automatically (and incorrectly) stop after one packet if started immediately after a View Capture operation
- User is prompted to stop transmit on a port first if he tries to apply configuration changes on a port in 'transmit' state
- OstProto service has a new method "modifyPort()"
- At port init port.isExclusive is now set using a bindconfig query (Win32 only)
- AbstractPort interface has 2 new pure virtual methods - hasExclusiveControl() and setExclusiveControl()
- PcapPort does not support this functionality (yet) so these methods return false
- WinPcapPort suppots this new functionality using bindconfig
- Port's notes (specifying Rx/Tx limitations) are now set and updated based on hasExclusiveControl()
- Presence of 'notes' on a port is indicated using a '*' after the port name in the port stats window
- The tabwidget has been removed from Port Window | Stream View Pane
- Ostinato Client has a new action in the port window's context menu for the same
- Port Icon in the Port Window is decorated based on exclusive control
- LinkState is now updated in PortWindow as soon as a change is detected; the required minimal refactoring of the Port class usage has been done
- Fixed a compiler warning in portgrouplist.cpp
Others
- PortStatsFilter: Ui change - added left and right arrow icons
- Port State (Link/Transmit/Capture) now updated alongwith port stats
- On link state change, the port window is not updated - partial changes have been done under #if 0; needs refactoring of Port Class implementation/usage before a signal/slot for the same can be implemented
Fixes
- Fixed crash in client when connection to server is broken
- Packet Capture and Capture Buffer Retrieval now works correctly and consistently (I think!)
Others
- Minor visual changes in Ports Window
- Port Stats Window now has 'right' alignment for stats data and 'center' for state data
