matthew/ostinato
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Start/stop the txStats thread along with txThread

Browse Source 
This will avoid having an always running thread unnecessarily
This commit is contained in:
Srivats P 2023-11-23 17:02:58 +05:30
parent 469e0b054e
commit cf84060277
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
server/pcaptransmitter.cpp
View File

@ -27,7 +27,6 @@ PcapTransmitter::PcapTransmitter(
txStats_.setObjectName(QString("TxStats:%1").arg(device)); txStats_.setObjectName(QString("TxStats:%1").arg(device));
memset(&stats_, 0, sizeof(stats_)); memset(&stats_, 0, sizeof(stats_));
txStats_.setTxThreadStats(&stats_); txStats_.setTxThreadStats(&stats_);
txStats_.start(); // TODO: alongwith user transmit start
txThread_.setStats(&stats_); txThread_.setStats(&stats_);
connect(&txThread_, SIGNAL(finished()), SLOT(updateTxThreadStreamStats())); connect(&txThread_, SIGNAL(finished()), SLOT(updateTxThreadStreamStats()));
@ -35,7 +34,6 @@ PcapTransmitter::PcapTransmitter(
PcapTransmitter::~PcapTransmitter() PcapTransmitter::~PcapTransmitter()
{ {
txStats_.stop(); // TODO: alongwith user transmit stop
} }
bool PcapTransmitter::setRateAccuracy( bool PcapTransmitter::setRateAccuracy(
@ -126,12 +124,20 @@ void PcapTransmitter::useExternalStats(AbstractPort::PortStats *stats)
void PcapTransmitter::start() void PcapTransmitter::start()
{ {
// XXX: Start the stats thread before the tx thread, so no tx stats
// is missed
txStats_.start();
Q_ASSERT(txStats_.isRunning());
txThread_.start(); txThread_.start();
} }
void PcapTransmitter::stop() void PcapTransmitter::stop()
{ {
// XXX: Stop the tx thread before the stats thread, so no tx stats
// is missed
txThread_.stop(); txThread_.stop();
Q_ASSERT(!txThread_.isRunning());
txStats_.stop();
} }
bool PcapTransmitter::isRunning() bool PcapTransmitter::isRunning()