matthew/ostinato
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use qFrom/ToBigEndian instead of ntohs/htons

Browse Source 
For consistency with rest of the code
This commit is contained in:
Srivats P 2023-04-13 18:10:43 +05:30
parent b2ad3c5d08
commit c91475d416
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/pcaptxthread.cpp
View File

@ -448,7 +448,7 @@ int PcapTxThread::sendQueueTransmit(pcap_t *p, PacketSequence *seq,
if (seq->ttagL4CksumOffset_) { if (seq->ttagL4CksumOffset_) {
quint16 *cksum = reinterpret_cast<quint16*>( quint16 *cksum = reinterpret_cast<quint16*>(
pkt + seq->ttagL4CksumOffset_); pkt + seq->ttagL4CksumOffset_);
origCksum = ntohs(*cksum); origCksum = qFromBigEndian<quint16>(*cksum);
// XXX: SignProtocol trailer // XXX: SignProtocol trailer
// ... | <guid> | 0x61 | 0x00 | 0x22 | 0x1d10c0da // ... | <guid> | 0x61 | 0x00 | 0x22 | 0x1d10c0da
// ... | <guid> | 0x61 | <TtagId> | 0x23 | 0x1d10c0da // ... | <guid> | 0x61 | <TtagId> | 0x23 | 0x1d10c0da
@ -464,7 +464,7 @@ int PcapTxThread::sendQueueTransmit(pcap_t *p, PacketSequence *seq,
// XXX: For IPv4/UDP, if ~newcksum is 0x0000 we are supposed to // XXX: For IPv4/UDP, if ~newcksum is 0x0000 we are supposed to
// set the checksum as 0xffff since 0x0000 indicates no cksum // set the checksum as 0xffff since 0x0000 indicates no cksum
// is present - we choose not to do this to avoid extra cost // is present - we choose not to do this to avoid extra cost
*cksum = htons(~newCksum); *cksum = qToBigEndian(quint16(~newCksum));
} }
ttagId_++; ttagId_++;
} }
@ -500,7 +500,7 @@ int PcapTxThread::sendQueueTransmit(pcap_t *p, PacketSequence *seq,
if (seq->ttagL4CksumOffset_) { if (seq->ttagL4CksumOffset_) {
quint16 *cksum = reinterpret_cast<quint16*>( quint16 *cksum = reinterpret_cast<quint16*>(
pkt + seq->ttagL4CksumOffset_); pkt + seq->ttagL4CksumOffset_);
*cksum = htons(origCksum); *cksum = qToBigEndian(origCksum);
} }
} }