From ad38a601712eb483c9ca3b184aac715fdc763c0d Mon Sep 17 00:00:00 2001
From: Srivats P <pstavirs@users.noreply.github.com>
Date: Mon, 4 May 2020 19:15:49 +0530
Subject: [PATCH] Fix valid count range for variable fields

To allow full range of a field, the "count" of a variable field,
 * Minimum should be 1, not 0
 * Maximum should be max value of field + 1

Fixes #301
---
 client/variablefieldswidget.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/client/variablefieldswidget.cpp b/client/variablefieldswidget.cpp
index df4dee7..2e10679 100644
--- a/client/variablefieldswidget.cpp
+++ b/client/variablefieldswidget.cpp
@@ -297,7 +297,7 @@ void VariableFieldsWidget::on_type_currentIndexChanged(int index)
         bitmask->setInputMask("HH");
         bitmask->setText("FF");
         valueRange_->setRange(0, 0xFF);
-        count->setRange(0, 0xFF);
+        count->setRange(1, 0x100);
         step->setRange(0, 0xFF);
         break;
     case OstProto::VariableField::kCounter16:
@@ -305,7 +305,7 @@ void VariableFieldsWidget::on_type_currentIndexChanged(int index)
         bitmask->setInputMask("HHHH");
         bitmask->setText("FFFF");
         valueRange_->setRange(0, 0xFFFF);
-        count->setRange(0, 0xFFFF);
+        count->setRange(1, 0x10000);
         step->setRange(0, 0xFFFF);
         break;
     case OstProto::VariableField::kCounter32:
@@ -313,7 +313,7 @@ void VariableFieldsWidget::on_type_currentIndexChanged(int index)
         bitmask->setInputMask("HHHHHHHH");
         bitmask->setText("FFFFFFFF");
         valueRange_->setRange(0, 0xFFFFFFFF);
-        count->setRange(0, 0x7FFFFFFF);
+        count->setRange(1, 0x7FFFFFFF); // XXX: QSpinBox max limited to int32
         step->setRange(0, 0x7FFFFFFF);
         break;
     default: