matthew/ostinato
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix incorect logic of isNewerVersion

Browse Source
This commit is contained in:
Srivats P 2016-09-17 15:21:31 +05:30
parent 523258442c
commit a8f9795c85
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
common/updater.cpp
View File

@ -37,6 +37,7 @@ Updater::Updater()
Q_ASSERT(isVersionNewer("10.1", "2") == true);
Q_ASSERT(isVersionNewer("0.10", "0.2") == true);
Q_ASSERT(isVersionNewer("1.10.1", "1.2.3") == true);
Q_ASSERT(isVersionNewer("0.7.1", "0.8") == false);
#endif
}
@ -120,8 +121,12 @@ bool Updater::isVersionNewer(QString newVersion, QString curVersion)
for (int i = 0; i < qMin(curVer.size(), newVer.size()); i++) {
bool isOk;
if (newVer.at(i).toUInt(&isOk) > curVer.at(i).toUInt(&isOk))
uint n = newVer.at(i).toUInt(&isOk);
uint c = curVer.at(i).toUInt(&isOk);
if (n > c)
return true;
else if (n < c)
return false;
}
if (newVer.size() > curVer.size())