matthew/ostinato
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

UX: Warn for very short duration stream transmits

Browse Source 
Changed the default num_packets from 1 to 10, because otherwise the
default stream values will trigger this warning, which is not a good
experience for the user
This commit is contained in:
Srivats P 2017-09-30 19:32:27 +05:30
parent 57e8fe7236
commit a757b9e353
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/protocol.proto
View File

@ -78,7 +78,7 @@ message StreamControl {
optional SendUnit unit = 1 [default = e_su_packets]; optional SendUnit unit = 1 [default = e_su_packets];
optional SendMode mode = 2 [default = e_sm_fixed]; optional SendMode mode = 2 [default = e_sm_fixed];
optional uint32 num_packets = 3 [default = 1]; optional uint32 num_packets = 3 [default = 10];
optional uint32 num_bursts = 4 [default = 1]; optional uint32 num_bursts = 4 [default = 1];
optional uint32 packets_per_burst = 5 [default = 10]; optional uint32 packets_per_burst = 5 [default = 10];
optional NextWhat next = 6 [default = e_nw_goto_next]; optional NextWhat next = 6 [default = e_nw_goto_next];

14
common/streambase.cpp
View File

@ -609,6 +609,20 @@ bool StreamBase::preflightCheck(QString &result) const
} }
} }
if (frameCount() <= averagePacketRate() && nextWhat() != e_nw_goto_id)
{
result += QObject::tr("Only %L1 frames at the rate of "
"%L2 frames/sec are configured to be transmitted - "
"transmission will last for only %L3 second "
"(if you wish to transmit for a longer duration, "
"increase the number of bursts/packets and/or set the "
"'After this stream' action as 'Goto First').\n")
.arg(frameCount())
.arg(averagePacketRate(), 0, 'f', 2)
.arg(frameCount()/averagePacketRate(), 0, 'f');
pass = false;
}
return pass; return pass;
} }