matthew/ostinato
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Stream stats UX improvements

Browse Source 
* Enable button only when one or more port is selected
* Reorder the button to make it first in the stats group
* Show some helpful text instead of a blank window when no stream stats
are available
This commit is contained in:
Srivats P 2017-12-06 20:47:26 +05:30
parent bfd31179dc
commit 92d4c260a0
3 changed files with 40 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
client/portstatswindow.cpp
View File

@ -108,6 +108,7 @@ void PortStatsWindow::when_tvPortStats_selectionChanged(
tbViewCapture->setDisabled(isEmpty); tbViewCapture->setDisabled(isEmpty);
tbClear->setDisabled(isEmpty); tbClear->setDisabled(isEmpty);
tbGetStreamStats->setDisabled(isEmpty);
tbResolveNeighbors->setDisabled(isEmpty); tbResolveNeighbors->setDisabled(isEmpty);
tbClearNeighbors->setDisabled(isEmpty); tbClearNeighbors->setDisabled(isEmpty);

32
client/portstatswindow.ui
View File

@ -78,6 +78,22 @@
</property> </property>
</widget> </widget>
</item> </item>
<item>
<widget class="QToolButton" name="tbGetStreamStats" >
<property name="toolTip" >
<string>Fetch Selected Port Stream Stats</string>
</property>
<property name="statusTip" >
<string>Fetches stream statistics from the selected port(s)</string>
</property>
<property name="text" >
<string>Fetch Stream Stats</string>
</property>
<property name="icon" >
<iconset resource="ostinato.qrc" >:/icons/stream_stats.png</iconset>
</property>
</widget>
</item>
<item> <item>
<widget class="QToolButton" name="tbClear"> <widget class="QToolButton" name="tbClear">
<property name="toolTip"> <property name="toolTip">
@ -112,22 +128,6 @@
</property> </property>
</widget> </widget>
</item> </item>
<item>
<widget class="QToolButton" name="tbGetStreamStats" >
<property name="toolTip" >
<string>Fetch Selected Port Stream Stats</string>
</property>
<property name="statusTip" >
<string>Fetches stream statistics from the selected port(s)</string>
</property>
<property name="text" >
<string>Fetch Stream Stats</string>
</property>
<property name="icon" >
<iconset resource="ostinato.qrc" >:/icons/stream_stats.png</iconset>
</property>
</widget>
</item>
<item> <item>
<widget class="Line" name="line_3"> <widget class="Line" name="line_3">
<property name="orientation"> <property name="orientation">

15
client/streamstatswindow.ui
View File

@ -1,3 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<ui version="4.0"> <ui version="4.0">
<class>StreamStatsWindow</class> <class>StreamStatsWindow</class>
<widget class="QWidget" name="StreamStatsWindow"> <widget class="QWidget" name="StreamStatsWindow">
@ -14,10 +15,15 @@
</property> </property>
<layout class="QHBoxLayout"> <layout class="QHBoxLayout">
<item> <item>
<widget class="QTableView" name="streamStats" > <widget class="XTableView" name="streamStats">
<property name="contextMenuPolicy"> <property name="contextMenuPolicy">
<enum>Qt::ActionsContextMenu</enum> <enum>Qt::ActionsContextMenu</enum>
</property> </property>
<property name="whatsThis">
<string>Oops! We don't seem to have any stream statistics for the requested port(s)
Wait a little bit to see if they appear, otherwise verify your stream stats configuration</string>
</property>
</widget> </widget>
</item> </item>
</layout> </layout>
@ -30,6 +36,13 @@
</property> </property>
</action> </action>
</widget> </widget>
<customwidgets>
<customwidget>
<class>XTableView</class>
<extends>QTableView</extends>
<header>xtableview.h</header>
</customwidget>
</customwidgets>
<resources/> <resources/>
<connections/> <connections/>
</ui> </ui>