matthew/ostinato
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ignore failures when stopping stream stats tracking

Browse Source 
Stop everything irrespective of any failures
This commit is contained in:
Srivats P 2023-03-22 16:42:54 +05:30
parent 682d0cc5c9
commit 823f01557b
1 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
server/pcapport.cpp
View File

@ -199,23 +199,24 @@ _tx_fail:
return false;
}
// FIXME: stop everything possible, don't revert in case of error
bool PcapPort::stopStreamStatsTracking()
{
if (!transmitter_->setStreamStatsTracking(false))
goto _tx_fail;
if (!txTtagStatsPoller_->stop())
goto _tx_ttag_fail;
if (!rxStatsPoller_->stop())
goto _rx_fail;
return true;
bool ret = true;
_rx_fail:
_tx_ttag_fail:
transmitter_->setStreamStatsTracking(true); // FIXME: needed?
_tx_fail:
qWarning("failed to stop stream stats tracking");
return false;
if (!transmitter_->setStreamStatsTracking(false)) {
qWarning("failed to stop Transmitter stream stats tracking");
ret = false;
}
if (!txTtagStatsPoller_->stop()) {
qWarning("failed to stop TxTtag stream stats thread");
ret = false;
}
if (!rxStatsPoller_->stop()) {
qWarning("failed to stop Rx stream stats thread");
ret = false;
}
return ret;
}
/*