matthew/ostinato
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove comment about trying read-write lock

Browse Source 
The stream timingHash is read by getStreamStats() while it is read/write
for processRecords(), the latter is a more frequent operation so there's
no real benefit of using a read-write lock instead of simple mutex.
This commit is contained in:
Srivats P 2023-04-27 11:15:26 +05:30
parent d3be505a0c
commit 3c6632b6a2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/streamtiming.h
View File

@ -86,7 +86,7 @@ private:
typedef uint GuidKey; typedef uint GuidKey;
typedef QHash<GuidKey, Timing> PortTiming; typedef QHash<GuidKey, Timing> PortTiming;
QHash<PortIdKey, PortTiming*> timing_; QHash<PortIdKey, PortTiming*> timing_;
QMutex timingLock_; // FIXME: change to RW lock? QMutex timingLock_;
QTimer *timer_; // Periodic timer to process tx/rx records QTimer *timer_; // Periodic timer to process tx/rx records
QTimer *gcTimer_; // Garbage collection for stale tx records QTimer *gcTimer_; // Garbage collection for stale tx records