Fix warnings introduced by recent feature development

client/devicegroupmodel.cpp

@@ -193,9 +193,9 @@ QVariant DeviceGroupModel::data(const QModelIndex &index, int role) const
 }
 
 bool DeviceGroupModel::setData(
-        const QModelIndex &index,
-        const QVariant &value,
-        int role)
+        const QModelIndex & /*index*/,
+        const QVariant & /*value*/,
+        int /*role*/)
 {
     if (!port_)
         return false;

client/portgroup.cpp

@@ -438,7 +438,7 @@ void PortGroup::processPortConfigList(PbRpcController *controller)
                                     .arg(port->userAlias())
                                     .arg(port->userName());
                         QMessageBox::warning(NULL, tr("Open Session"), warning);
-                        qWarning(qPrintable(warning));
+                        qWarning("%s", qPrintable(warning));
                         continue;
                     }
                     atConnectPortConfig_[j] = pc;
@@ -585,7 +585,7 @@ void PortGroup::processDeleteDeviceGroupAck(PbRpcController *controller)
     delete controller;
 }
 
-void PortGroup::processModifyDeviceGroupAck(int portIndex,
+void PortGroup::processModifyDeviceGroupAck(int /*portIndex*/,
         PbRpcController *controller)
 {
     qDebug("In %s", __FUNCTION__);

client/portswindow.cpp

@@ -192,7 +192,7 @@ int PortsWindow::reservedPortCount()
 //! Always return true
 bool PortsWindow::openSession(
         const OstProto::SessionContent *session,
-        QString &error)
+        QString & /*error*/)
 {
     QProgressDialog progress("Opening Session", NULL,
                              0, session->port_groups_size(), mainWindow);
@@ -223,7 +223,7 @@ bool PortsWindow::openSession(
  */
 bool PortsWindow::saveSession(
         OstProto::SessionContent *session, // OUT param
-        QString &error,
+        QString & /*error*/,
         QProgressDialog *progress)
 {
     int n = portGroupCount();

client/stream.cpp

@@ -50,12 +50,18 @@ void Stream::storeProtocolWidgets()
     return;
 }
 
-quint64 getDeviceMacAddress(int portId, int streamId, int frameIndex)
+quint64 getDeviceMacAddress(
+        int /*portId*/,
+        int /*streamId*/,
+        int /*frameIndex*/)
 {
     return 0;
 }
 
-quint64 getNeighborMacAddress(int portId, int streamId, int frameIndex)
+quint64 getNeighborMacAddress(
+        int /*portId*/,
+        int /*streamId*/,
+        int /*frameIndex*/)
 {
     return 0;
 }

server/devicemanager.cpp

@@ -40,7 +40,7 @@ inline UInt128 UINT128(OstEmul::Ip6Address x)
 
 inline bool isMacMcast(quint64 mac)
 {
-    return (mac >> 40) & 0x01 == 0x01;
+    return ((mac >> 40) & 0x01) == 0x01;
 }
 
 

server/myservice.cpp

@@ -843,9 +843,9 @@ _invalid_port:
 }
 
 void MyService::resolveDeviceNeighbors(
-    ::google::protobuf::RpcController* controller,
+    ::google::protobuf::RpcController* /*controller*/,
     const ::OstProto::PortIdList* request,
-    ::OstProto::Ack* response,
+    ::OstProto::Ack* /*response*/,
     ::google::protobuf::Closure* done)
 {
     qDebug("In %s", __PRETTY_FUNCTION__);
@@ -869,9 +869,9 @@ void MyService::resolveDeviceNeighbors(
 }
 
 void MyService::clearDeviceNeighbors(
-    ::google::protobuf::RpcController* controller,
+    ::google::protobuf::RpcController* /*controller*/,
     const ::OstProto::PortIdList* request,
-    ::OstProto::Ack* response,
+    ::OstProto::Ack* /*response*/,
     ::google::protobuf::Closure* done)
 {
     qDebug("In %s", __PRETTY_FUNCTION__);

server/pcapport.cpp

@@ -984,8 +984,8 @@ void PcapPort::EmulationTransceiver::run()
     flags |= PCAP_OPENFLAG_NOCAPTURE_LOCAL;
 #endif
 
-_retry:
 #ifdef Q_OS_WIN32
+_retry:
     // NOCAPTURE_LOCAL needs windows only pcap_open()
     handle_ = pcap_open(qPrintable(device_), 65535,
                 flags, 100 /* ms */, NULL, errbuf);