matthew/ostinato
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't fix incorrect checksum for Ttag packets

Browse Source 
See comments in code
This commit is contained in:
Srivats P 2023-04-26 10:01:24 +05:30
parent 6ba942d00f
commit 0afc150264
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
server/packetsequence.h
View File

@ -71,8 +71,16 @@ public:
streamStatsMeta_[guid].tx_bytes += pktHeader->caplen; streamStatsMeta_[guid].tx_bytes += pktHeader->caplen;
} }
} }
// TODO: A PacketSequence belongs to a unique stream only in case of
// sequential streams; for interleaved streams, we have only a single
// packet set (with one or more sequences) containing packets from
// multiple streams. To support this, we need to make l4cksum a packet
// property not a sequence property
// Till the above is fixed, Ttag packets will have wrong checksum
#if 0
if (trackGuidStats_ && (packets_ == 1)) // first packet of seq if (trackGuidStats_ && (packets_ == 1)) // first packet of seq
ttagL4CksumOffset_ = Packet::l4ChecksumOffset(pktData, pktHeader->caplen); ttagL4CksumOffset_ = Packet::l4ChecksumOffset(pktData, pktHeader->caplen);
#endif
return ret; return ret;
} }
pcap_send_queue *sendQueue_; pcap_send_queue *sendQueue_;