From b131b07af8a67399e966113e1bd2e9ad2568f36e Mon Sep 17 00:00:00 2001 From: Tobias Genannt Date: Thu, 16 Mar 2023 07:50:24 +0100 Subject: [PATCH] Simplified basse image check --- build-functions/get-public-image-config.sh | 5 ----- build.sh | 5 +++-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/build-functions/get-public-image-config.sh b/build-functions/get-public-image-config.sh index 054efd2..70c292c 100644 --- a/build-functions/get-public-image-config.sh +++ b/build-functions/get-public-image-config.sh @@ -6,11 +6,6 @@ get_image_label() { skopeo inspect "docker://$image" | jq -r ".Labels[\"$label\"]" } -get_image_layers() { - local image=$1 - skopeo inspect "docker://$image" | jq -r ".Layers" -} - get_image_last_layer() { local image=$1 skopeo inspect "docker://$image" | jq -r ".Layers | last" diff --git a/build.sh b/build.sh index 6d79160..d1c08e4 100755 --- a/build.sh +++ b/build.sh @@ -324,11 +324,11 @@ else source ./build-functions/get-public-image-config.sh echo "Checking labels for '${FINAL_DOCKER_TAG}'" BASE_LAST_LAYER=$(get_image_last_layer "${DOCKER_FROM}") - mapfile -t IMAGES_LAYERS_OLD < <(get_image_layers "${FINAL_DOCKER_TAG}") + OLD_BASE_LAST_LAYER=$(get_image_label netbox.last-base-image-layer "${FINAL_DOCKER_TAG}") NETBOX_GIT_REF_OLD=$(get_image_label netbox.git-ref "${FINAL_DOCKER_TAG}") GIT_REF_OLD=$(get_image_label org.opencontainers.image.revision "${FINAL_DOCKER_TAG}") - if ! printf '%s\n' "${IMAGES_LAYERS_OLD[@]}" | grep -q -P "^${BASE_LAST_LAYER}\$"; then + if [ "${BASE_LAST_LAYER}" != "${OLD_BASE_LAST_LAYER}" ]; then SHOULD_BUILD="true" BUILD_REASON="${BUILD_REASON} ubuntu" fi @@ -388,6 +388,7 @@ fi if [ -n "${BUILD_REASON}" ]; then BUILD_REASON=$(sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//' <<<"$BUILD_REASON") DOCKER_BUILD_ARGS+=(--label "netbox.build-reason=${BUILD_REASON}") + DOCKER_BUILD_ARGS+=(--label "netbox.last-base-image-layer=${BASE_LAST_LAYER}") fi # --build-arg