matthew/The-Powder-Toy
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix crash in GameSave::serialiseOPS

Browse Source 
Only particlesCount particles have been copied from the Simulation.
All the rest are uninitialised, and may have coordinates outside the
game area. Using those uninitialised coordinates in the index for
partsPosFirstMap may cause a crash.
This commit is contained in:
jacksonmj 2012-12-16 22:56:03 +00:00
parent d29c77b2d5
commit 9c6f3c7fbb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/client/GameSave.cpp
View File

@ -1701,7 +1701,7 @@ char * GameSave::serialiseOPS(int & dataLength)
partsPosLastMap = (unsigned int *)calloc(fullW*fullH, sizeof(unsigned)); partsPosLastMap = (unsigned int *)calloc(fullW*fullH, sizeof(unsigned));
partsPosCount = (unsigned int *)calloc(fullW*fullH, sizeof(unsigned)); partsPosCount = (unsigned int *)calloc(fullW*fullH, sizeof(unsigned));
partsPosLink = (unsigned int *)calloc(NPART, sizeof(unsigned)); partsPosLink = (unsigned int *)calloc(NPART, sizeof(unsigned));
for(i = 0; i < NPART; i++) for(i = 0; i < particlesCount; i++)
{ {
if(particles[i].type) if(particles[i].type)
{ {