matthew/The-Powder-Toy
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make request progress variables atomic

Browse Source 
These are the only bit of shared state between the Request user thread and RequestManager that aren't covered by RequestHandle::stateMx. The problem was that they were not covered by anything, which meant that they were not guaranteed to be coherent between threads.
This commit is contained in:
Tamás Bálint Misius 2023-02-01 19:26:59 +01:00
parent b7a6663e08
commit 85d492bad6
No known key found for this signature in database
GPG Key ID: 5B472A12F6ECA9F2
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/client/http/requestmanager/RequestManager.h
View File

@ -1,6 +1,7 @@
#pragma once #pragma once
#include "common/ExplicitSingleton.h" #include "common/ExplicitSingleton.h"
#include "common/String.h" #include "common/String.h"
#include <atomic>
#include <thread> #include <thread>
#include <vector> #include <vector>
#include <memory> #include <memory>
@ -36,8 +37,8 @@ namespace http
State state = ready; State state = ready;
std::mutex stateMx; std::mutex stateMx;
std::condition_variable stateCv; std::condition_variable stateCv;
int bytesTotal = 0; std::atomic<int> bytesTotal = 0;
int bytesDone = 0; std::atomic<int> bytesDone = 0;
int statusCode = 0; int statusCode = 0;
ByteString responseData; ByteString responseData;
std::vector<ByteString> responseHeaders; std::vector<ByteString> responseHeaders;