From 7a875dd846ba7f28e54350e5f3b9d8836b7d069d Mon Sep 17 00:00:00 2001 From: Simon Robertshaw Date: Tue, 31 May 2011 00:05:01 +0100 Subject: [PATCH] Fix buffer overflow with huge error message --- src/luaconsole.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/luaconsole.c b/src/luaconsole.c index bc6a2cc9a..8b8c22242 100644 --- a/src/luaconsole.c +++ b/src/luaconsole.c @@ -61,6 +61,7 @@ void luacon_close(){ int process_command_lua(pixel *vid_buf, char *console, char *console_error) { int commandret; + char * tmp_error; char console2[15]; char console3[15]; char console4[15]; @@ -74,8 +75,11 @@ int process_command_lua(pixel *vid_buf, char *console, char *console_error) return -1; } else { commandret = luacon_eval(console); - if (commandret) - strcpy(console_error, luacon_geterror()); + if (commandret){ + tmp_error = luacon_geterror(); + strncpy(console_error, tmp_error, 254); + printf("%s\n", tmp_error); + } } } return 1;