matthew/The-Powder-Toy
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix ToArray duplicating the last byte of its input

Browse Source 
Apparently, you have to read() before you check status bits. Who woulda thunk.

This never manifested because all the files we ever embedded this way ended in a newline. I needed a report from someone who uses a text editor that doesn't ensure this.
This commit is contained in:
Tamás Bálint Misius 2022-01-15 15:46:59 +01:00
parent f5bc2a5f0d
commit 622161e563
No known key found for this signature in database
GPG Key ID: 5B472A12F6ECA9F2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
data/ToArray.cpp
View File

@ -20,6 +20,8 @@ int main(int argc, char *argv[])
auto dataLen = 0U; auto dataLen = 0U;
while (true) while (true)
{ {
char ch;
inputAny.read(&ch, 1);
if (inputAny.eof()) if (inputAny.eof())
{ {
break; break;
@ -28,8 +30,6 @@ int main(int argc, char *argv[])
{ {
return 3; return 3;
} }
char ch;
inputAny.read(&ch, 1);
outputCpp << (unsigned int)(unsigned char)(ch) << ", "; outputCpp << (unsigned int)(unsigned char)(ch) << ", ";
dataLen += 1; dataLen += 1;
} }