matthew/The-Powder-Toy
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix element identifiers not being accepted by tpt __newindex

Browse Source 
Becuase *of course* whether it succeds or not depends on whether you've rebuilt menus.

With all seriousness, the real culprit here is GameModel::GetToolFromIdentifier, which looks for tools in the menu section tool lists, plus another list with tools that aren't in any menu section. This is absolutely blaphemous, but I don't feel like refactoring this right now. It also wouldn't be a problem in itself, but allocating an element also doesn't rebuild these lists, only changing the MenuSection property and a few other obscure operations do. This makes allocating elements also rebuild these lists.
This commit is contained in:
Tamás Bálint Misius 2021-07-14 08:48:42 +02:00
parent a463180e2a
commit 11188c85c3
No known key found for this signature in database
GPG Key ID: 5B472A12F6ECA9F2
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lua/LuaScriptInterface.cpp
View File

@ -2827,6 +2827,7 @@ int LuaScriptInterface::elements_allocate(lua_State * l)
luacon_ci->custom_can_move[elem][newID] = 0; luacon_ci->custom_can_move[elem][newID] = 0;
luacon_ci->custom_can_move[newID][elem] = 0; luacon_ci->custom_can_move[newID][elem] = 0;
} }
luacon_model->BuildMenus();
luacon_ci->custom_init_can_move(); luacon_ci->custom_init_can_move();
} }